From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 05 Feb 2012 20:45:52 GMT
Subject: Re: [PATCH v4 4/4] completion: simplify __gitcomp*
Message-ID: <7vmx8xggan.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120204135404.GF16099@goldbirke>

SZEDER Gábor <szeder@ira.uka.de> writes:

> And it does make a difference, it breaks the completion of a single
> word in multiple steps, e.g. git log --pretty=<TAB> master..<TAB>.  In
> such cases we pass "${cur##--pretty=}" and "${cur_#*..}" as third
> argument to __gitcomp() and __gitcomp_nl(), which can be empty strings
> when the user hits TAB right after the '=' and '..'.

After saying "this rewrite is wrong", I was actually wondering if I should
have said "this rewrite is not faithful to the original".  Based on your
analysis, the difference does break the callers, so the rewrite is indeed
wrong.

Thanks for following up.