From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 12 Apr 2012 17:43:33 GMT
Subject: Re: [PATCH v2] tests: add initial bash completion tests
Message-ID: <7vmx6g6e2i.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s2Ug91_sQ-XR3ck2k+x+eQRt9PNRRBOUnkrnNRhY6fEpw@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> On Thu, Apr 12, 2012 at 12:57 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>
>> +test_expect_success 'double dash' '
>> +       cat >expected <<-\EOF &&
>> +       --paginate
>> +       --no-pager
>> +       --git-dir=
>> +       --bare
>> +       --version
>> +       --exec-path
>> +       --html-path
>> +       --work-tree=
>> +       --namespace=
>> +       --help
>> +       EOF
>> +       test_completion "git --"
>
> There's a mistake here ^.

Yeah, good eyes!  ... ah, wait, it is your bug ;-)

Thanks.

I wonder if it may make more sense to have this as two separate tests,
though...

> --- b/t/t9902-completion.sh
> +++ a/t/t9902-completion.sh
> @@ -96,7 +96,7 @@ test_expect_success 'double dash' '
>         --namespace=
>         --help Z
>         EOF
> -       test_completion "git --"
> +       test_completion "git --" &&
>
>         sed -e "s/Z$//" >expected <<-\EOF &&
>         --quiet Z