From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Sep 2012 16:52:49 GMT
Subject: Re: [PATCH] completion: fix shell expansion of items
Message-ID: <7vmx0kbpr2.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120920014608.GA27782@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Thu, Sep 20, 2012 at 04:15:15AM +0200, Felipe Contreras wrote:
>
>> As reported by Jeroen Meijer[1]; the current code doesn't deal properly
>> with items (tags, branches, etc.) that have ${} in them because they get
>> expaned by bash while using compgen.
>> 
>> A simple solution is to quote the items so they get expanded properly
>> (\$\{\}).
>> 
>> In order to achieve that I took bash-completion's quote() function,
>> which is rather simple, and renamed it to __git_quote() as per Jeff
>> King's suggestion.
>> 
>> Solves the original problem for me.
>
> Me too. Thanks.

Thanks, both.  Will queue.