From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Oct 2012 18:23:44 GMT
Subject: Re: Proposed function path_in_directory()
Message-ID: <7vmwzwlt5b.fsf@alter.siamese.dyndns.org>
In-Reply-To: <50731968.7020602@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Am 08.10.2012 18:13, schrieb Junio C Hamano:
>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>>> 2. Does there need to be any special related to DOS paths?
>> 
>> The ceiling computation may need special case for dos.  What does
>> the getcwd() give us?  Do we learn only the path within the "current
>> drive" and need to prefix C: (or D: or X:) ourselves if we really
>> want to tell C:\bin and D:\bin apart?
>
> We don't have to do that. getcwd() returns the drive letter.
> ...
> A component in an path list like GIT_CEILING_DIRECTORIES or PATH that
> does not contain the drive letter is a user error. Do not cater for it.

That makes it much simpler and saner.  Thanks.