From: Junio C Hamano Date: Thu, 17 Jan 2013 20:43:06 GMT Subject: Re: [PATCH v2 6/8] git-remote-testpy: hash bytes explicitly Message-ID: <7vmww7tuat.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vtxqftulq.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > John Keeping writes: > >> Under Python 3 'hasher.update(...)' must take a byte string and not a >> unicode string. Explicitly encode the argument to this method as UTF-8 >> so that this code works under Python 3. >> >> This moves the required Python version forward to 2.0. >> >> Signed-off-by: John Keeping >> --- > > Hmph. So what happens when the path is _not_ encoded in UTF-8? Oh, my brain was not working. Forget this part, and sorry for the noise. We are not decoding a bytestring to an array of unicode characters, but going the other way around here.