From: Junio C Hamano Date: Tue, 23 Apr 2013 17:29:11 GMT Subject: Re: [PATCH 1/7] am: suppress error output from a conditional Message-ID: <7vmwspi2ag.fsf@alter.siamese.dyndns.org> In-Reply-To: Ramkumar Ramachandra writes: > Martin von Zweigbergk wrote: >> On Tue, Apr 23, 2013 at 7:01 AM, Ramkumar Ramachandra >> wrote: >>> When testing if the $dotest directory exists, and if $next is greater >>> than $last >> >> When can that happen? If one edits the todo? > > When git-rebase.sh creates a $dotest directory with just an autostash file :) > > Like I said in my cover letter, I really wrote [7/7] first, and kept > modifying things until all the tests passed. So, I can't really > justify these changes independent of [7/7]. That explains a lot of mystery ;-) Perhaps all of these "oops, 7/7 breaks this and that so let's work them around" can be avoided if the series did not store the object name of the stash that records the local changes as a plain text file inside a $dotest/ directory, and instead used a dedicated ref somewhere under refs/ hierarchy, no?