From: Junio C Hamano Date: Tue, 25 Oct 2005 18:56:01 GMT Subject: Re: [PATCH] Make fetch-pack play nicer with servers which do not speak multi_ack Message-ID: <7vll0he88u.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: >> But you are right. If you made 20 commits on top of my "master" >> branch head, we should send those 20 (and the commit you based >> on your changes, which the other end has), way before sending >> the ancient v0.99 tag. Probably, we should never be sending >> v0.99 tag as "have" if we are going to send your "master" branch >> head, since the commit that tag refers to is reachable by your >> "master" branch head but there are a lot more commit between >> them, some of which will give us better "common" selected, and >> that v0.99 tag is what the other end said they have so is known >> to be ACKed if sent. > > You´re right. Complete common refs are sent even if they are ancestors of > other complete common refs. I´ll think about that. I just realized that I have two refs you would rather send the last while fetching from me most of the time: junio-gpg-pub tag and todo head. If you manage to get acked either by non multi aware remote before saying "have" on anything on the main branch, I think you would get *everything* back --- which is quite bad.