From: Junio C Hamano Date: Sun, 04 Dec 2005 23:01:52 GMT Subject: [PATCH] compat/setenv: do not free what we fed putenv(3). Message-ID: <7vlkz0eaan.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <28409.1133564908@lotus.CS.Berkeley.EDU> Signed-off-by: Junio C Hamano --- compat/setenv.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) 3a2674337c12e958f8c697af991a0ef6c06ddd4d diff --git a/compat/setenv.c b/compat/setenv.c index 94acd2d..b7d7678 100644 --- a/compat/setenv.c +++ b/compat/setenv.c @@ -16,7 +16,7 @@ int gitsetenv(const char *name, const ch namelen = strlen(name); valuelen = strlen(value); - envstr = malloc((namelen + valuelen + 2) * sizeof(char)); + envstr = malloc((namelen + valuelen + 2)); if (!envstr) return -1; memcpy(envstr, name, namelen); @@ -25,7 +25,11 @@ int gitsetenv(const char *name, const ch envstr[namelen + valuelen + 1] = 0; out = putenv(envstr); + /* putenv(3) makes the argument string part of the environment, + * and changing that string modifies the environment --- which + * means we do not own that storage anymore. Do not free + * envstr. + */ - free(envstr); return out; } -- 0.99.9.GIT