From: Junio C Hamano <junkio@cox.net>
Date: Fri, 09 Dec 2005 08:06:02 GMT
Subject: Re: [PATCH] use "git init-db" in tests
Message-ID: <7vlkyu7l05.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0512082336i674932bapd631d559e80cad79@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

> An accident? Like a filesystem not supporting executable permission?
> What is the reason to report success from the test run in that conditions?

Let's be reasonable.  I was hoping to hear from you a real-world
breakage case that I overlooked due to my lack of access to
platforms you may have access to.  I am not interested in a
theoretical failure case discussion very much.  If your
filesystem does not support executables, why do you expect
things to run from the freshly built directory to begin with?

Linkage error of git-init-db (or git wrapper) may leave the file
created but leave that in unexecutable form, which could be a
valid concern, but that would signal an error to the make during
the build stage, and "test" target depends on "all" target.

And please do not start arguing that you can cd to 't' directory
after such a build failure and manually say "make".  You can do
that without even running make at the top level and cause the
same failure.  I consider both of them pilot errors.