From: Junio C Hamano <junkio@cox.net>
Date: Sun, 05 Feb 2006 05:48:18 GMT
Subject: Re: [PATCH] do not open editor in dumb terminal
Message-ID: <7vlkwqmk4d.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.64.0602042346380.25300@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

> I think that "ed" is a bit too obscure as something for people to use 
> interactively, and emacsclient is obviously not a sane default (since 
> people might not be using emacs in server mode). Probably the right thing 
> is to have it supply a default if the terminal isn't dumb, and abort with 
> an error if there is no editor set after defaults are supplied.

I tend to agree (I am a minority who used ed for a long time,
but I am well aware that I _am_ a minority).  If somebody wants
to send in a tested patch to be applied, I would suggest to
replace EDITOR=ed in the one I sent out with an error message
and exit(1).