From: Junio C Hamano Date: Tue, 11 Jul 2006 09:15:34 GMT Subject: Re: [PATCH] t1400-update-ref: set VISUAL=true as well as EDITOR=true Message-ID: <7vlkr04i4p.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <11526072802855-git-send-email-normalperson@yhbt.net> Eric Wong writes: > I have VISUAL set in my environment, and it caused git-commit to > spawn my editor during the test. I think it would be better to remove "EDITOR=: VISUAL=:" settings from annotate-tests.sh, t1400-update-ref.sh and t4013-diff-various.sh, and move that to test-lib.sh; there is no point overriding them differently in each of these automated tests.