From: Junio C Hamano Date: Tue, 24 Oct 2006 06:46:49 GMT Subject: Re: [PATCH] Fix bad usage of mkpath in builtin-branch.sh Message-ID: <7vlkn6qkh2.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <1161655176461-git-send-email-hjemli@gmail.com> Lars Hjemli writes: > When checking if a branch start point referred to a commit-object, > the result of mkpath() was used as argument to get_sha1(), which > didn't work out as planned. > > Now it's xstrdup'd first. > > Signed-off-by: Lars Hjemli > --- > builtin-branch.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/builtin-branch.c b/builtin-branch.c > index ffc2db0..f86bf68 100755 I've already fixed up this perm-mode breakage (and other breakages, possibly) so when I am done with these patches tonight please resync with me.