From: Junio C Hamano Date: Wed, 16 May 2007 18:49:51 GMT Subject: Re: [PATCH] import-tars: Use the "Link indicator" to identify directories Message-ID: <7vlkfoeh80.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <7vsl9weie0.fsf@assigned-by-dhcp.cox.net> Junio C Hamano writes: > Johannes Schindelin writes: > >> Earlier, we used the mode to determine if a name was associated with >> a directory. This fails, since some tar programs do not set the mode >> correctly. However, the link indicator _has_ to be set correctly. Nah, what was I smoking. Even gtar seems to give mode="0000775" (with NUL termination) for directories, so there is no way there were regressions. Patch looks good. Acked-by: Junio C Hamano