From: Junio C Hamano Date: Tue, 30 Oct 2007 08:29:22 GMT Subject: Re: [PATCH/RFC 0/3] faster inexact rename handling Message-ID: <7vlk9lm2e5.fsf@gitster.siamese.dyndns.org> In-Reply-To: Linus Torvalds writes: > On Tue, 30 Oct 2007, Jeff King wrote: >> >> - no improvement on smaller datasets. Running "git-whatchanged -M >> --raw -l0" on the linux-2.6 repo takes about the same time with the >> old and new code (presumably the algorithmic savings of the new code >> are lost in a higher constant factor, so when n is small, it is a >> wash). > > Have you compared the results? IOW, does it find the *same* renames? > > I'm a bit worried about the fact that you just pick a single (arbitrary) > src/dst per fingerprint. Yes, it should be limited, but that seems to be a > bit too *extremely* limited. But if it gives the same results in practice, > maybe nobody cares? If it always gives the same results in practice, obviously nobody can even notice. However, merging this series to 'pu' breaks rebase-merge test t3402 among other things.