From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 22 Apr 2008 18:04:03 GMT
Subject: Re: [PATCH v2 04/13] Teach rebase interactive the mark command
Message-ID: <7vlk35ydf0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080422095549.GB3752@alea.gnuu.de>

Jörg Sommer <joerg@alea.gnuu.de> writes:

> What do you think about this version:
>
> cleanup_before_quit () {
> 	rm -rf "$DOTEST" &&
> 	for ref in $(git for-each-ref --format='%(refname)' ${mark_prefix%/})
> 	do
> 		git update-ref -d "$ref" "$ref" || return 1
> 	done
> }

Yeah, except you would want to dqquote "${mark_prefix%/}" part.

Also this being a "clean-up" phase, I wonder if we want to stop at the
first error (e.g. should unremovable "$DOTEST" leave marks behind?  should
unremovable one mark leave other marks that happen to sort after it
behind?).