From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 05 May 2008 05:14:32 GMT
Subject: Re: [PATCH] git-cherry: add color to the output
Message-ID: <7vlk2pnxhj.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080505032718.GA15498@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Fri, May 02, 2008 at 08:01:44PM +0200, Richard Quirk wrote:
>
>> If color.diff is set then patches not yet cherry-picked are marked green
>> and already picked ones are marked red. This makes it easier to tell at a
>> glance which changes have not been cherry-picked.
>
> I don't actually use git-cherry, so I can't say whether this is useful
> or not. But I wonder if it should follow the trend of other color
> options and get its own color.cherry variable, but also be controlled by
> the master color.ui.

I do not use git-cherry as Porcelain nor did I design it to be used as
such.  "color.cherry = always" would worry me but the user is asking for
trouble if he did so, so perhaps it is Ok.