From: Junio C Hamano <gitster@pobox.com>
Date: Sat, 09 Aug 2008 23:20:36 GMT
Subject: Re: [PATCH] tests: use $TEST_DIRECTORY to refer to the t/ directory
Message-ID: <7vljz54vy3.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <489E1FDB.5070700@free.fr>

Olivier Marin <dkr+ml.git@free.fr> writes:

> Junio C Hamano a écrit :
>> 
>> all the tests still pass, but we would want extra sets of eyeballs on this
>> type of change to really make sure.
>
> OK, I read the diff and found some trivial quoting issues that will break the
> following tests if $TEST_DIRECTORY contain a space:
>
>>  t/t4101-apply-nonl.sh                    |    2 +-
>>  t/t5100-mailinfo.sh                      |   18 +++++++++---------
>>  t/t7500-commit.sh                        |   16 ++++++++--------

Ah, GIT_EDITOR is dereferenced twice.  Sheesh.

We could probably use test_set_editor() function from test-lib.sh, hmm?