From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 19 Jan 2009 23:10:56 GMT
Subject: Re: [PATCH 2/2] expand --pretty=format color options
Message-ID: <7vljt6q4cf.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20090118195342.GA612@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Hrm. OK, it doesn't actually work always. It does for git-log, but not
> for rev-list, which leaves diff_use_color_default as -1. I don't know if
> there are any other ways you can get to this code path without having
> set diff_use_color_default.

Yuck, no matter what you do please don't contaminate plumbing with the UI
color options.

> Maybe it is time to do a cleanup on the color handling, which has
> provided no end of these bugs. I will have to leave that for another
> day, though.