From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Mar 2009 05:44:53 GMT
Subject: Re: [PATCHv2 3/3] format-patch: --numbered-files and --stdout aren't mutually exclusive
Message-ID: <7vljqy8622.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1237696363-6819-4-git-send-email-bebarino@gmail.com>

Stephen Boyd <bebarino@gmail.com> writes:

> For example:
>
>     git format-patch --numbered-files --stdout --attach HEAD~~
>
> will create two messages with files 1 and 2 attached respectively.
> There is no effect when using --numbered-files and --stdout together
> without an --attach or --inline, the files simply aren't created.

Hmm, "the files aren't created" is true, but I had to scratch my head if
you are describing a bug or justifying the change by saying "so filename
does not matter".

I think the change makes sense.  It could be argued that combination of
these two options should give a warning("ignoring --numbered"), but I do
not think it is even worth it.