From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 31 Jul 2009 14:51:41 GMT
Subject: Re: [PATCH] gitweb: fix 'Use of uninitialized value' error in href()
Message-ID: <7vljm4x5vm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <cb7bb73a0907310137o6adb57a5tb05b6745b41b0f01@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

> 2009/7/31 Jakub Narebski <jnareb@gmail.com>:
>> On Fri, 31 July 2009, Giuseppe Bilotta wrote:
>>>
>>> The funny thing is that I seem to get the error for something as simple
>>> as a commit view (_any_ commit view, for the matter), but I wasn't able
>>> to reproduce it from the shell, which is why I'm not adding a testcase.
>>
>> Gaaah! A Heisenbug! ;-)
>
> Well, I can reproduce it consistently on the gitweb repository, with
> any shortlog or commit view. I also think I understand why it happens
> (i.e. in some cases the check for file_parent eq file_name is done
> before calling href). The question, of course, is why wouldn't it
> happen in the test repository.

That sounds like something worth figuring out, independent of the issue
this patch addresses.