From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Aug 2009 01:54:29 GMT
Subject: Re: [PATCH] Check return value of ftruncate call in http.c. Remove possible mem leak
Message-ID: <7vljls5t7u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1249709881-31334-1-git-send-email-jeff.lasslett@gmail.com>

Jeff Lasslett <jeff.lasslett@gmail.com> writes:

> In new_http_object_request(), check ftruncate() call return value and
> handle possible errors.  Remove possible leak of mem pointed to by url.

Are you assuming that everybody is running libcurl 7.17.0 or later?
Before that version strings given to easy_setopt() were not copied and you
needed to keep them around.

I think freeing url is fine but you would probably need to then give
freq->url to easy_setopt(CURLOPT_URL) if you wanted to do so.