From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 29 Oct 2009 03:24:08 GMT
Subject: Re: [RFC PATCH v4 05/26] Move "get_ack()" back to fetch-pack
Message-ID: <7vljiudgrr.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1256774448-7625-6-git-send-email-spearce@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

> In 41cb7488 Linus moved this function to connect.c for reuse inside
> of the git-clone-pack command.  That was 2005, but in 2006 Junio
> retired git-clone-pack in commit efc7fa53.  Since then the only
> caller has been fetch-pack.  Since this ACK/NAK exchange is only
> used by the fetch-pack/upload-pack protocol we should keep move
> it back to a private detail of fetch-pack.

Should we keep it there or should we move it?  which? ;-)