From: Junio C Hamano Date: Fri, 26 Feb 2010 05:57:15 GMT Subject: Re: [PATCH] Having keywords without value is not a global error. Message-ID: <7vljegczes.fsf@alter.siamese.dyndns.org> In-Reply-To: Steven Drake writes: >> > if (!strcmp(k, "init.templatedir")) >> > return git_config_pathname(&init_db_template_dir, k, v); >> >> But then don't you need to catch init.templatedir does have a string >> value? > > Yes, but the change dose not touch that test,... Ahh, config_pathname() does its own check for NULLness, Ok, I forgot. Thanks.