From: Junio C Hamano Date: Sat, 05 Jun 2010 06:44:34 GMT Subject: Re: [PATCH v3 3/3] commit::print_summary(): set rev_info.always_show_header to 1 Message-ID: <7vljau0yi5.fsf@alter.siamese.dyndns.org> In-Reply-To: <1275639660-5344-1-git-send-email-rctay89@gmail.com> Tay Ray Chuan writes: > - mention the die() and our assumption that it won't be triggered, as > suggested by Junio. What I meant was to state that in the die() message, not in the commit log, so that a bug reporter (or preferably people hacking on git that introduces a regression to trigger this die()) can quickly diagnose what assumption this new code relies on was violated.