From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 24 Aug 2010 16:31:08 GMT
Subject: Re: [PATCH v2 2/3] fetch-pack: use args.shallow to detect shallow clone instead of args.depth
Message-ID: <7vlj7wx99v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1282565304-3122-2-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
> ---

Isn't there any rationale for this change?  "args.depth > 0 does not
necessarily mean we are in a shallow clone situation, because ..." or
"using args.depth > 0 to check if we are in a shallow clone breaks under
such and such conditions and here is a test case to reproduce the bug"?