From: Junio C Hamano Date: Wed, 20 Oct 2010 06:31:52 GMT Subject: Re: [PATCH] t4203 (mailmap): stop hardcoding commit ids and dates Message-ID: <7vlj5twf1j.fsf@alter.siamese.dyndns.org> In-Reply-To: <7vsk01wf65.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Junio C Hamano writes: > >> Jonathan Nieder writes: >> >>> Here's a better fix. Still no idea about the other failures Ævar >>> and Thomas were seeing. >> >> I saw intermittent failures too. Thanks for the objid fix. > > I found a way to reliably make this fail at test #7. > > $ sh t4203-mailmap.sh > Without the input redirection, things seem to work Ok. > > Still puzzled... Ah, of course. t/t4203-mailmap.sh | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh index a267d07..e818de6 100755 --- a/t/t4203-mailmap.sh +++ b/t/t4203-mailmap.sh @@ -114,7 +114,7 @@ test_expect_success 'name entry after email entry' ' mkdir -p internal_mailmap && echo " " >internal_mailmap/.mailmap && echo "Internal Guy " >>internal_mailmap/.mailmap && - git shortlog >actual && + git shortlog HEAD >actual && test_cmp expect actual ' @@ -131,7 +131,7 @@ test_expect_success 'name entry after email entry, case-insensitive' ' mkdir -p internal_mailmap && echo " " >internal_mailmap/.mailmap && echo "Internal Guy " >>internal_mailmap/.mailmap && - git shortlog >actual && + git shortlog HEAD >actual && test_cmp expect actual '