From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 06 Jan 2011 20:32:56 GMT
Subject: Re: [PATCH 2/3] t0001,t1510,t3301: use sane_unset which always returns with status 0
Message-ID: <7vlj2xai2v.fsf@alter.siamese.dyndns.org>
In-Reply-To: <gmeXEearzUOUEst4-B2b8nKnIcuDy8iOxR9s9wmOFYzBZT5rwFSFsnedLx8orqTDP1ztkJap7K8@cipher.nrlssc.navy.mil>

Thanks; there are a bit more from 

 $git grep -n -e '^[ 	]*unset[ 	].*&&' t

* t/t4150-am.sh:132:	unset test_tick &&

This should be safe, as we have already run test_tick to set it earlier.

* t/t5560-http-backend-noserver.sh:20:	unset REQUEST_METHOD &&
* t/t5560-http-backend-noserver.sh:33:	unset REQUEST_METHOD &&
* t/t5560-http-backend-noserver.sh:34:	unset CONTENT_TYPE &&

The varilable was earlier set inside the same function; safe.

* t/t5601-clone.sh:167:		unset GIT_CONFIG_NOGLOBAL &&

test-lib.sh sets this for us and this unsets it inside a subshell; safe.

* t/t6032-merge-large-rename.sh:98:	unset GIT_MERGE_VERBOSITY &&

test-lib.sh sets this for us and this unsets it; safe.

However, this unsets the variable permanently, damaging the environment
for tests other people later may add at the end of the script, which is
bad.  But that is outside the scope of your fix.

* t/t9130-git-svn-authors-file.sh:99:		unset GIT_CONFIG_NOGLOBAL &&
* t/t9130-git-svn-authors-file.sh:100:		unset GIT_DIR &&

test-lib.sh and then lib-git-svn.sh set these for us and this unsets them
inside a subshell; safe.

* t/t9130-git-svn-authors-file.sh:101:		unset GIT_CONFIG &&

As far as I can tell, this is unsafe; nobody has set GIT_CONFIG up to this
point.

* t/t9200-git-cvsexportcommit.sh:324:	 unset GIT_DIR &&

test-lib.sh sets this for us and this unsets it inside a subshell; safe.