From: Junio C Hamano Date: Wed, 06 Jul 2011 21:21:03 GMT Subject: Re: [PATCH 13/14] revert: Introduce --continue to continue the operation Message-ID: <7vliwbjebk.fsf@alter.siamese.dyndns.org> In-Reply-To: <1309938868-2028-14-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra writes: > diff --git a/builtin/revert.c b/builtin/revert.c > index 9e18d64..6ef56ee 100644 > --- a/builtin/revert.c > +++ b/builtin/revert.c > @@ -47,6 +47,7 @@ struct replay_opts { > enum replay_action action; > > int reset; > + int contin; As Jonathan mentiond, these three look like all action's to me. > +static void verify_opt_mutually_compatible(const char *me, ...) > +{ Isn't "being compatible" by definition "mutual"? I.e. verify-option-compatibility perhaps?