From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Sep 2011 19:03:36 GMT
Subject: Re: [PATCH 1/3] make-static: master
Message-ID: <7vlitrt08n.fsf@alter.siamese.dyndns.org>
In-Reply-To: <4E704EA2.8060307@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Am 9/14/2011 1:46, schrieb Junio C Hamano:
>> This kind of breakage report was exactly what I was looking for by
>> merging it early to 'next'. Hopefully no other (function / platform) combo
>> has such dependencies...
>
> There is! prepare_git_cmd is used from the Windows section in run-command.c.
> Therefore, the following hunks of the patch should be reverted.

Sorry, I do not think it should just be "reverted".

Instead, a new comment should be added to explain why it needs to be
exposed, which was the _whole_ point of the message you are replying to,
in which I showed how it should be done by an example.