From: Junio C Hamano Date: Sun, 04 Mar 2012 23:12:13 GMT Subject: Re: [PATCH v2 03/10] cat-file: use streaming interface to print blobs Message-ID: <7vling6jw2.fsf@alter.siamese.dyndns.org> In-Reply-To: <1330865996-2069-4-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > +static int write_blob(const unsigned char *sha1) > +{ > + unsigned char new_sha1[20]; > + > + if (sha1_object_info(sha1, NULL) == OBJ_TAG) { Hrm, didn't I say that it tastes bad for a function write_blob() to have to worry about OBJ_TAG already?