From: Junio C Hamano Date: Sat, 31 Mar 2012 23:45:21 GMT Subject: Re: [PATCH 3/3] revision: insert unsorted, then sort in prepare_revision_walk() Message-ID: <7vlimgibce.fsf@alter.siamese.dyndns.org> In-Reply-To: <4F7780F5.3060306@lsrfire.ath.cx> René Scharfe writes: > Speed up prepare_revision_walk() by adding commits without sorting > to the commit_list and at the end sort the list in one go. Thanks > to mergesort() working behind the scenes, this is a lot faster for > large numbers of commits than the current insert sort. This is one of these moments I am reminded why I am grateful to have you in the community. The first message from you in a topic that needs to touch a quite core part of the system often is not a participation in the discussion, but is a solution that is already well crafted. Thanks, will queue.