From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 15 May 2012 15:22:49 GMT
Subject: Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument
Message-ID: <7vliktfoza.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAH3Anrr11eLiHkasdLxAWD9--B6QNq5-kFfO+Xg1F5xTDS56zg@mail.gmail.com>

Jon Seymour <jon.seymour@gmail.com> writes:

> On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> The only reason why the original is not ordered that way, as far as I can
>> tell, is because "It is recommended that" was part of an existing paragraph
>> when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12)
>> added "An optional ...", so it was tucked after existing paragraph without
>> reading the resulting whole to see if "at the very end" was the best place.
>
> Re-reading this, I don't think the advice:
>
>     "It is recommended that you run 'git svn' fetch and rebase (not
>     pull or merge) your commits against the latest changes in the =C2=A0SVN
>     repository."
>
> really belongs in the description of dcommit at all.

I tend to agree.  Opinions from git-svn experts?