From: Junio C Hamano <junkio@cox.net>
Date: Sat, 21 May 2005 20:10:26 GMT
Subject: Re: [PATCH 3/3] Diff overhaul, adding the other half...
Message-ID: <7vk6lsgx1p.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0505211137250.2206@ppc970.osdl.org>

>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> Hmm.. It's not working well. Not only does it take a lot of
LT> CPU time...

LT> 	torvalds@ppc970:~/v2.6/linux> wc -c drivers/media/dvb/bt8xx/dst_ca.h drivers/usb/misc/emi62_fw_m.h
LT> 	  1591 drivers/media/dvb/bt8xx/dst_ca.h
LT> 	795679 drivers/usb/misc/emi62_fw_m.h
LT> 	797270 total

Yup.  diffcore-rename bases the similarity index on the average
of src and dst files.  Maybe the similarity check should also
say they should be comparable size, like this upfront before
even going into delta:

    abs(src-dst) < avg(src,dst) * (1 - minscore/maxscore)