From: Junio C Hamano Date: Thu, 23 Mar 2006 23:32:58 GMT Subject: Re: [RFC] Silent File Mods Being Committed Message-ID: <7vk6ak4tzp.fsf@assigned-by-dhcp.cox.net> In-Reply-To: <20060323214710.GV18185@pasky.or.cz> Petr Baudis writes: > Dear diary, on Thu, Mar 23, 2006 at 06:13:21AM CET, I got a letter > where Junio C Hamano said that... >> (2) audit all the scripts to make sure they do not get upset if >> we add trailing +/- to the status letter, and do that >> unconditionally, like the attached patch does. > > Cogito will get upset since we assume the mode field is one-char in our > regexps, and when we don't, we compare the mode field with strings and > that would obviously fail if you add random stuff to it. > > Otherwise, I like this idea, though. Likewise. If it was not obvious, I am not going to commit that myself. If jdl or somebody cares enough, he or she can prepare a a set of patches to git-core, Cogito and StGIT (at least these three should be covered) to teach them the trailing +/- letter, _and_ parrot my patch back at me. Hint, hint...