From: Junio C Hamano <junkio@cox.net>
Date: Tue, 31 Oct 2006 01:47:14 GMT
Subject: Re: [PATCH] Continue traversal when rev-list --unpacked finds a packed commit.
Message-ID: <7vk62hs1ct.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061031013749.GA19885@delft.aura.cs.cmu.edu>

Jan Harkes <jaharkes@cs.cmu.edu> writes:

> When getting the list of all unpacked objects by walking the commit history,
> we would stop traversal whenever we hit a packed commit. However the fact
> that we found a packed commit does not guarantee that all previous commits
> are also packed. As a result the commit walkers did not show all reachable
> unpacked objects.
>
> Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>

Thanks.

With this, I think revs->unpacked should not mean "limited", so
I suspect this is also needed, no?

diff --git a/revision.c b/revision.c
index 93f2513..2d7cad9 100644
--- a/revision.c
+++ b/revision.c
@@ -1010,7 +1010,7 @@ int setup_revisions(int argc, const char
 		add_pending_object(revs, object, def);
 	}
 
-	if (revs->topo_order || revs->unpacked)
+	if (revs->topo_order)
 		revs->limited = 1;
 
 	if (revs->prune_data) {