From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 28 Oct 2007 11:32:12 GMT
Subject: Re: [PATCH 6/7] include $PATH in generating list of commands for "help -a"
Message-ID: <7vk5p7v5j7.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193570329-11656-1-git-send-email-srp@srparish.net>

Scott R Parish <srp@srparish.net> writes:

> +	while (1) {
> +		if ((colon = strchr(path, ':')))
> +			*colon = 0;
> +
> +		len = list_commands_in_dir(&other_cmds, path);
> +		longest = MAX(longest, len);

Where do we borrow this MAX() macro?

On Linux with glibc, /usr/include/sys/param.h which is included
by git-compat-util.h (meaning, for everybody) is where we find
it, but that somehow does not sound portable assumption.