From: Junio C Hamano Date: Wed, 14 Nov 2007 08:47:48 GMT Subject: Re: [PATCH] Improved and extended t5404 Message-ID: <7vk5olkybv.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20071114071929.GA2942@steel.home> Alex Riesen writes: > Junio C Hamano, Wed, Nov 14, 2007 01:02:20 +0100: >> Alex Riesen writes: >> >> > Ignore exit code of git push in t5404, as it is not relevant for the >> > test >> >> This proposed log message solicits a "Huh? -- Since when >> ignoring exit code is an improvement?" reaction. If this push >> is expected to error out, then wouldn't you want to make sure it >> errors out as expected? If the problem is that the exit status >> is unreliable, maybe we need to make it reliable instead? > > Well, it is kind of undefined. git push just updated some remote > references and failed on the others. It has had some failures, so it > returns non-0. And as I said, it really is not about the operation, > but about if the tracking and remote branches are set as we want them. Ok, I guess the proposed log message was not clear enough, at least for me. Will apply.