From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Feb 2008 00:34:25 GMT
Subject: Re: [PATCH 0/3] solaris test results
Message-ID: <7vk5kz171q.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080220235944.GA6278@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

>   - Sun's diff doesn't understand "-u". I was able to use GNU diff.
>     Since comparing actual and expected output is so common, we could
>     potentially abstract this with a "test_cmp()" function and use
>     something platform specific. It's probably not worth the trouble, as
>     it impacts only the test suite, and only on systems with a totally
>     broken diff.

It is unfair to call diff without -u "totally broken".  It is
not even in POSIX yet IIRC.

>   - t7505 uses a hook which hard-codes /bin/sh but uses syntax that
>     the Solaris /bin/sh doesn't like. Maybe hooks should get their
>     $SHELL value replaced?

You've already did that in your [PATCH 2/3], haven't you?  So
why not?