From: Junio C Hamano Date: Sun, 09 Mar 2008 03:39:21 GMT Subject: Re: [PATCH] git-quiltimport: better parser to grok "enhanced" series files. Message-ID: <7vk5kcsh06.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080308182709.GA3109@artemis.madism.org> Pierre Habouzit writes: > I'd even argue that it's maint material btw :) I don't know. You made the loop a subshell but I think you can redirect into the while loop without an extra "cat" process. Can a patch name contain $IFS whitespace characters? If so, this patch would regress them. Otherwise it looks fine.