From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 02 Jun 2008 04:59:26 GMT
Subject: Re: [PATCH v3] perl/Git.pm: add parse_rev method
Message-ID: <7vk5h8a0up.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <484327FB.8080105@gmail.com>

Lea Wiemann <lewiemann@gmail.com> writes:

> Miklos Vajna wrote:
>> Lea Wiemann <lewiemann@gmail.com> wrote:
>>> Is there *any* name for the identifiers you pass into git-rev-parse
>>> (like HEAD^2 or master:test/foo.txt)?
>>
>> `man git-rev-parse` calls them "revisions". Yes, even the commit:path
>> ones.
>
> True -- it's quite cringeworthy indeed. ;)  As long as it only affects
> the documentation for that particular method, I'll go with "revision".

I think that is sensible, and the method can stay parse_rev, not get_hash,
don't you think?