From: Junio C Hamano Date: Fri, 18 Jul 2008 06:26:46 GMT Subject: Re: Re* git-remote SEGV on t5505 test. Message-ID: <7vk5fjd7x5.fsf@gitster.siamese.dyndns.org> In-Reply-To: <7vsku7d8ak.fsf_-_@gitster.siamese.dyndns.org> Junio C Hamano writes: > SungHyun Nam writes: > >> Is it possible that we can use 'SHELL_PATH' here? > > It is not just possible but we really should. There are other test > scripts that use hardcoded /bin/sh, but by setting SHELL_PATH the user is > already telling us that what the vendor has in /bin/sh isn't adequately > POSIX enough, and we really should try to honor that. > > "git grep -n /bin/sh t/t*sh | grep -v ':1:#!'" would tell you which ones > are suspect. SungHyun, I did not test this patch myself (all my shells grok $() command substitutions), so I won't be committing this until/unless I see a "tested on system X and works fine".