From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 06 Nov 2008 17:06:59 GMT
Subject: Re: [PATCH/RFC v3] git add -i: Answer questions with a single keypress
Message-ID: <7vk5bgiy18.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200811060815.16797.sunaku@gmail.com>

"Suraj N. Kurapati" <sunaku@gmail.com> writes:

> On Thursday 06 November 2008 00:42:36 Jeff King wrote:
>> On Wed, Nov 05, 2008 at 09:59:25AM -0800, Suraj N. Kurapati wrote:
>> > Allows the user to answer 'Stage this hunk' questions with a
>> > single keypress, just like in Darcs.  Previously, the user was
>> > forced to press the Return key after every choice they made.
>> > This quickly becomes tiring, burdensome work for the fingers.
>>
>> I think this is a reasonable goal, but I have a few questions/concerns.
>>
>>  - There are three versions of your patch, but nobody has commented.
>>    Clearly we can see what changed, but it is not clear what advantage
>>    one patch has over the other. Care to elaborate?
>
> v1 and v2 make the mistake of setting raw mode, which prevent the user from 
> pressing Control-C to exit the program.  v3 fixes this by using cbreak mode.

When I was reading the last round I noticed the above change myself, but
it is customary to write this kind of "patch changelog" under --- line in
your patch around here.  That way you can save everybody's time.

Thanks.  And thanks, Jeff, for being a good reviewer.