From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 19 Dec 2010 03:23:29 GMT
Subject: Re: [PATCH 2/2] fill_textconv(): Don't get/put cache if sha1 is not valid
Message-ID: <7vk4j6fnta.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101218205514.GA21249@landau.phys.spbu.ru>

Kirill Smelkov <kirr@landau.phys.spbu.ru> writes:

> Thanks for your ACK and for the explanation.
>
> My last patches to git were blame related so semi-intuitively I knew
> that invalid sha1 are coming from files in worktree. Your description
> makes things much more clear and I'd put it into patch log as well.
> What is the best practice for this? For me to re-roll, or for Junio to
> merge texts?

Re-rolling to explain changes in your own words is preferred; thanks.