From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 20 Jun 2011 21:53:58 GMT
Subject: Re: [PATCH 2/3] Add a lot of dummy returns to avoid warnings with NO_NORETURN
Message-ID: <7vk4cgb24p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vsjr4b3tf.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> I think this is probably a bad move, given that the previous patch is a
> temporary workaround until gcc 4.6 is fixed. With -Wunreachable-code on,
> these will introduce noise for build without NO_NORETURN (either when
> profile feedback is not used, or when profile feedback build is in use and
> it no longer requires the NO_NORETURN workaround).

I would need to clarify with s/introduce noise/introduce more noise/; the
existing codebase is not noise-free.

But I do not see much point in making things worse, only to squelch
"reaches end of non void function" warnings that will be given under the
NO_NORETURN workaround configuration.