From: Junio C Hamano Date: Fri, 14 Oct 2011 18:59:04 GMT Subject: Re: [PATCH 0/6] http-auth-early Message-ID: <7vk487z9fr.fsf@alter.siamese.dyndns.org> In-Reply-To: <20111014131932.GE7808@sigill.intra.peff.net> Jeff King writes: > Your changes all look right. The naming of git_getpass_one in the > cherry-picked commit is a little odd without the rest of the series as > context. I would maybe have called it "git_getpass_with_description" or > something. Thanks both; will queue with that updated function name.