From: Junio C Hamano Date: Sun, 13 Nov 2011 20:30:55 GMT Subject: Re: [PATCH 1/2] Convert many resolve_ref() calls to read_ref*() and ref_exists() Message-ID: <7vk473ojcw.fsf@alter.siamese.dyndns.org> In-Reply-To: <1321179735-21890-1-git-send-email-pclouds@gmail.com> Nguyễn Thái Ngọc Duy writes: > Convert all these call sites to new wrappers to reduce resolve_ref() > calls from 57 to 34. If we change resolve_ref() prototype later on > to avoid passing static buffer out, this helps reduce changes. Indeed the result is very nice and it is almost trivial to see that the result does not change any behaviour without looking outside the context. Thanks.