From: Junio C Hamano Date: Mon, 10 Dec 2012 20:05:47 GMT Subject: Re: Use of a mailmap file with git-log Message-ID: <7vk3spad0k.fsf@alter.siamese.dyndns.org> In-Reply-To: Antoine Pelisse writes: > Yet I'm afraid it could be: > 1. expensive to rewrite all commit log (reallocating the buffer) > 2. Inappropriate to change the value in function that is supposed to > read In my suggestion I avoided rewriting the log buffer, primarily because of #2 (in addition to "read" cleanliness, such a change may break the gpg signature checking for merges). We do reencode the contents before we write it out when "encoding" is present, so logically such a rewrite of authors and committers belongs to where that happens, in pretty_print_commit(). Note that this existing rewrite is not done to the commit log buffer but is to a separate buffer meant to be used only for output.