From: Junio C Hamano Date: Wed, 16 Jan 2013 16:53:29 GMT Subject: Re: [PATCH] fix some clang warnings Message-ID: <7vk3rdxe5y.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130116160410.GC22400@sigill.intra.peff.net> Jeff King writes: > On Wed, Jan 16, 2013 at 03:53:23PM +0100, Max Horn wrote: > >> -#ifdef __GNUC__ >> +#if defined(__GNUC__) && ! defined(__clang__) >> #define config_error_nonbool(s) (config_error_nonbool(s), -1) >> #endif > > You don't say what the warning is, but I'm guessing it's complaining > about throwing away the return value from config_error_nonbool? Yeah, I was wondering about the same thing. The other one looks similar, ignoring the return value of error(). Also, is this "some versions of clang do not like this"? Or are all versions of clang affected?