From: Junio C Hamano Date: Mon, 04 Feb 2013 17:24:03 GMT Subject: Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support Message-ID: <7vk3qo2dsc.fsf@alter.siamese.dyndns.org> In-Reply-To: <87sj5cvxnf.fsf_-_@lifelogs.com> [administrivia: I would really wish you didn't put "Mail-copies-to: never" above]. Ted Zlatanov writes: > +foreach my $v (values %{$options{tmap}}) > +{ > + $options{tmap}->{$v} = $v; > +} Please follow the styles of existing Perl scripts, e.g. indent with tab, etc. Style requests are not optional; it is a prerequisite to make the patch readable and reviewable. > + print < + ... > +EOHIPPUS Do we really need to refer readers to Wikipedia or something to learn about extinct equid ungulates ;-)?