From: Junio C Hamano Date: Sun, 03 Mar 2013 21:08:50 GMT Subject: Re: [PATCH] Revert "graph.c: mark private file-scope symbols as static" Message-ID: <7vk3pob38d.fsf@alter.siamese.dyndns.org> In-Reply-To: <20130303102946.GH7738@serenity.lan> John Keeping writes: > On Sat, Mar 02, 2013 at 08:16:13PM +0100, Thomas Rast wrote: >> John Keeping writes: >> >> > This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. >> > >> > CGit uses these symbols to output the correct HTML around graph >> > elements. Making these symbols private means that CGit cannot be >> > updated to use Git 1.8.0 or newer, so let's not do that. >> > >> > Signed-off-by: John Keeping >> > --- >> > >> > I realise that Git isn't a library so making the API useful for outside >> > projects isn't a priority, but making these two methods public makes >> > life a lot easier for CGit. >> > >> > Additionally, it seems that Johan added graph_set_column_colors >> > specifically so that CGit should use it - there's no value to having >> > that as a method just for its use in graph.c and he was the author of >> > CGit commit 268b34a (ui-log: Colorize commit graph, 2010-11-15). >> >> Perhaps you could add a comment in the source to prevent this from >> happening again? > ... > I would hope that having this message in the history should be enough to > prevent this changing in the future.... Given how it happened in the first place, I do not think anything short of in-code comment would have helped. There wouldn't be any hint to look into the history without one.